adamsaghy commented on code in PR #3206:
URL: https://github.com/apache/fineract/pull/3206#discussion_r1217665972
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/event/external/service/ExternalEventServiceTest.java:
##########
@@ -122,7 +131,8 @@ public void testPostEventShouldWorkWithRegularEvent()
throws IOException {
given(idempotencyKeyGenerator.generate(event)).willReturn(idempotencyKey);
given(serializerFactory.create(event)).willReturn(eventSerializer);
given(eventSerializer.getSupportedSchema()).will(invocation ->
LoanAccountDataV1.class);
- given(eventSerializer.serialize(event)).willReturn(data);
+ given(eventSerializer.toAvroDTO(event)).willReturn(new
LoanAccountDataV1());
+
given(byteBufferConverter.convert(any(ByteBuffer.class))).willReturn(data);
Review Comment:
I might be wrong, but i dont see any places where it was verified the data
enricher was called and provided the right value...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
