adamsaghy commented on code in PR #3232:
URL: https://github.com/apache/fineract/pull/3232#discussion_r1219682213
##########
fineract-provider/src/main/java/org/apache/fineract/batch/exception/ErrorHandler.java:
##########
@@ -99,13 +99,13 @@ public static ErrorInfo handler(final RuntimeException
exception) {
return handleException(e, new PlatformDomainRuleExceptionMapper(),
9999);
}
if (exception instanceof TransactionException) {
- return new ErrorInfo(HttpStatus.SC_BAD_REQUEST, 4001,
"{\"Exception\": %s}".formatted(exception.getMessage()));
+ return new ErrorInfo(HttpStatus.SC_INTERNAL_SERVER_ERROR, 4001,
"{\"Exception\": %s}".formatted(exception.getMessage()));
Review Comment:
if you are changing this for 5xx error, you should change the code as well
(4001 -> 5000 or 5003?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
