reluxa commented on code in PR #3250:
URL: https://github.com/apache/fineract/pull/3250#discussion_r1228018295
##########
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##########
@@ -89,7 +93,8 @@ public Loan execute(Loan loan) {
private void handleSale(final Loan loan, final LocalDate settlementDate,
final ExternalAssetOwnerTransfer externalAssetOwnerTransfer) {
ExternalAssetOwnerTransfer newExternalAssetOwnerTransfer =
sellAsset(loan, settlementDate, externalAssetOwnerTransfer);
- // TODO: trigger asset loan transfer executed event
+ businessEventNotifierService.notifyPreBusinessEvent(new
LoanOwnershipTransferBusinessEvent(newExternalAssetOwnerTransfer, loan));
Review Comment:
done
##########
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##########
@@ -102,7 +107,8 @@ private void handleBuyback(final Loan loan, final LocalDate
settlementDate,
.orElseThrow();
ExternalAssetOwnerTransfer newExternalAssetOwnerTransfer =
buybackAsset(loan, settlementDate, buybackExternalAssetOwnerTransfer,
activeExternalAssetOwnerTransfer);
- // TODO: trigger asset loan transfer executed event
+ businessEventNotifierService.notifyPreBusinessEvent(new
LoanOwnershipTransferBusinessEvent(newExternalAssetOwnerTransfer, loan));
Review Comment:
done
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanRepaymentBusinessEventSerializerTest.java:
##########
@@ -86,6 +90,7 @@ public void setUp() {
ThreadLocalContextUtil.setActionContext(ActionContext.DEFAULT);
ThreadLocalContextUtil
.setBusinessDates(new
HashMap<>(Map.of(BusinessDateType.BUSINESS_DATE,
LocalDate.now(ZoneId.systemDefault()))));
+ // when(dataEnricherProcessor.enrich(any())).thenAnswer(a ->
a.getArguments()[0]);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
