adamsaghy commented on code in PR #3260:
URL: https://github.com/apache/fineract/pull/3260#discussion_r1235322301
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsHelper.java:
##########
@@ -161,6 +161,8 @@ private LocalDate
determineInterestPostingPeriodEndDateFrom(final LocalDate peri
}
periodEndDate =
periodEndDate.with(TemporalAdjusters.lastDayOfMonth());
break;
+ case ACTIVATIONDATE:
Review Comment:
Can you please explain the math here?
Quote from the story:
_Assuming a customer's Fixed Deposit or Recurring Deposit account is
activated on Jan 20, we post interest to the customer's account on Feb 20 and
on the 20th of every subsequent month until the duration of the account lapses.
So for a 6 month Fixed Deposit Account interest would be posted on Feb 20, Mar
20, Apr 20, May 20, June 20 and July 20._
So this is a kind of monthly interest posting...the difference is it is
using the activation day + 1 month period, right? I am wondering whether an
"ACTIVATION_DATE_MONTHLY" would be better name. Thoughts?
@bharathc27 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
