adamsaghy commented on code in PR #3286:
URL: https://github.com/apache/fineract/pull/3286#discussion_r1252687168
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -2668,8 +2668,11 @@ private void
compareDisbursedToApprovedOrProposedPrincipal(BigDecimal disbursedA
if (this.loanProduct().isDisallowExpectedDisbursements() &&
this.loanProduct().isAllowApprovedDisbursedAmountsOverApplied()) {
BigDecimal maxDisbursedAmount = getOverAppliedMax();
- if (disbursedAmount.compareTo(maxDisbursedAmount) > 0) {
- final String errorMessage = "Loan disbursal amount can't be
greater than maximum applied loan amount calculation.";
+ if (totalDisbursed.compareTo(maxDisbursedAmount) > 0) {
Review Comment:
Are you sure the `totalDisbursed` is containing this "newly" disbursed
amount already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
