taskain7 commented on code in PR #3320:
URL: https://github.com/apache/fineract/pull/3320#discussion_r1270867094
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransaction.java:
##########
@@ -98,24 +99,23 @@ public class ClientTransaction extends
AbstractAuditableWithUTCDateTimeCustom {
protected ClientTransaction() {}
public static ClientTransaction payCharge(final Client client, final
Office office, PaymentDetail paymentDetail,
- final LocalDate transactionDate, final Money amount, final String
currencyCode) {
+ final LocalDate transactionDate, final Money amount, final String
currencyCode, final ExternalId externalId) {
final boolean isReversed = false;
- final String externalId = null;
return new ClientTransaction(client, office, paymentDetail,
ClientTransactionType.PAY_CHARGE.getValue(), transactionDate, amount,
isReversed, externalId, currencyCode);
}
public static ClientTransaction waiver(final Client client, final Office
office, final LocalDate transactionDate, final Money amount,
final String currencyCode) {
final boolean isReversed = false;
- final String externalId = null;
+ final ExternalId externalId = null;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
