adamsaghy commented on code in PR #3322:
URL: https://github.com/apache/fineract/pull/3322#discussion_r1273878342
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeWritePlatformServiceImpl.java:
##########
@@ -509,6 +509,10 @@ public CommandProcessingResult waiveLoanCharge(final Long
loanId, final Long loa
existingTransactionIds, existingReversedTransactionIds,
loanInstallmentNumber, scheduleGeneratorDTO, accruedCharge,
externalId);
+ if (loanCharge.isInstalmentFee()) {
Review Comment:
why do we need this? Waive loan charge functionality is not really relating
to the transaction processing of reverse-replaying...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
