ruchiD commented on code in PR #3333:
URL: https://github.com/apache/fineract/pull/3333#discussion_r1274375640
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualWritePlatformServiceImpl.java:
##########
@@ -385,10 +385,9 @@ private void
updateChargeForSubmittedOnDate(Collection<LoanChargeData> chargesDa
LocalDate scheduleEndDate = accrualData.getDueDateAsLocaldate();
for (LoanChargeData loanCharge : chargesData) {
BigDecimal chargeAmount = BigDecimal.ZERO;
- if (((accrualData.getInstallmentNumber() == 1 &&
loanCharge.getSubmittedOnDate().isEqual(startDate))
- || loanCharge.getSubmittedOnDate().isBefore(startDate) ||
loanCharge.getSubmittedOnDate().isEqual(startDate)
- || loanCharge.getSubmittedOnDate().isAfter(startDate)) &&
!loanCharge.getSubmittedOnDate().isAfter(endDate)
- && !loanCharge.getDueDate().isBefore(startDate) &&
!loanCharge.getDueDate().isAfter(scheduleEndDate)) {
+ if (((accrualData.getInstallmentNumber() == 1 &&
loanCharge.getSubmittedOnDate().isEqual(startDate)
Review Comment:
This condition was to check if charge is submitted and is due on
disbursement date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
