adamsaghy commented on code in PR #3352:
URL: https://github.com/apache/fineract/pull/3352#discussion_r1281531120


##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java:
##########
@@ -518,17 +519,19 @@ public static LocalDate convertFrom(final String 
dateAsString, final String para
         return convertDateTimeFrom(dateAsString, parameterName, dateFormat, 
clientApplicationLocale).toLocalDate();
     }
 
-    public static LocalDateTime convertDateTimeFrom(final String 
dateTimeAsString, final String parameterName, final String dateTimeFormat,
+    public static LocalDateTime convertDateTimeFrom(final String 
dateTimeAsString, final String parameterName, String dateTimeFormat,

Review Comment:
   `extractLocalDateTimeNamed` was missed. I reckon that method should be also 
enhanced.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to