reluxa commented on code in PR #3367:
URL: https://github.com/apache/fineract/pull/3367#discussion_r1291332327


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -2954,6 +2956,51 @@ private void handleDisbursementTransaction(final 
LocalDate disbursedOn, final Pa
 
     }
 
+    public void handleDownPayment(final BigDecimal disbursedAmount, final 
JsonCommand command,
+            final ScheduleGeneratorDTO scheduleGeneratorDTO) {
+        if (isAutoRepaymentForDownPaymentEnabled()) {
+            LocalDate disbursedOn = 
command.localDateValueOfParameterNamed(ACTUAL_DISBURSEMENT_DATE);
+            BigDecimal disbursedAmountPercentageForDownPayment = 
this.loanRepaymentScheduleDetail
+                    .getDisbursedAmountPercentageForDownPayment();
+            ExternalId externalId = ExternalId.empty();
+            if 
(TemporaryConfigurationServiceContainer.isExternalIdAutoGenerationEnabled()) {
+                externalId = ExternalId.generate();
+            }
+            Money downPaymentMoney = Money.of(getCurrency(), 
percentageOf(disbursedAmount, disbursedAmountPercentageForDownPayment));
+            LoanTransaction downPaymentTransaction = 
LoanTransaction.downPayment(getOffice(), downPaymentMoney, null, disbursedOn,
+                    externalId);
+            /**

Review Comment:
   It's a minor / cosmetic issue. The compiler settings that we use creates a 
warning when javadoc style comment is used inside of a method body. We can just 
change this to block coment. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to