adamsaghy commented on code in PR #3377:
URL: https://github.com/apache/fineract/pull/3377#discussion_r1297268986
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -2527,11 +2528,11 @@ &&
isNoneOrCashOrUpfrontAccrualAccountingEnabledOnLoanProduct()) {
}
private void
regenerateRepaymentScheduleWithInterestRecalculationIfNeeded(boolean
interestRecalculationEnabledParam,
- boolean disbursementMissedParam, ScheduleGeneratorDTO
scheduleGeneratorDTO) {
+ boolean disbursementMissedParam, ScheduleGeneratorDTO
scheduleGeneratorDTO, final boolean downPaymentEnabled) {
LocalDate firstInstallmentDueDate =
fetchRepaymentScheduleInstallment(1).getDueDate();
- if (interestRecalculationEnabledParam
- &&
(firstInstallmentDueDate.isBefore(DateUtils.getBusinessLocalDate()) ||
disbursementMissedParam)) {
+ if ((interestRecalculationEnabledParam
+ &&
(firstInstallmentDueDate.isBefore(DateUtils.getBusinessLocalDate()) ||
disbursementMissedParam)) || downPaymentEnabled) {
Review Comment:
I am not sure i like the idea to mix downpayment logic into
`regenerateRepaymentScheduleWithInterestRecalculationIfNeeded` method :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
