adamsaghy commented on code in PR #3366:
URL: https://github.com/apache/fineract/pull/3366#discussion_r1299820066
##########
fineract-loan/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingWritePlatformServiceImpl.java:
##########
@@ -278,6 +278,77 @@ public void createSavingProductToGLAccountMapping(final
Long savingProductId, fi
this.savingsProductToGLAccountMappingHelper.savePaymentChannelToFundSourceMappings(command,
element, savingProductId, null);
this.savingsProductToGLAccountMappingHelper.saveChargesToIncomeAccountMappings(command,
element, savingProductId, null);
break;
+
+ case ACCRUAL_PERIODIC:
+ // asset
Review Comment:
It would be better to extract these into a method and then you can extract
the common mappings of cash and accrual based mapping also to reduce code
duplications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
