marta-jankovics commented on code in PR #3386:
URL: https://github.com/apache/fineract/pull/3386#discussion_r1302275042
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/search/service/SearchUtil.java:
##########
@@ -173,7 +232,9 @@ public static Object parseAndValidateColumnValue(final
ResultsetColumnHeaderData
if (StringUtils.isEmpty(columnValue)) {
return columnValue;
}
- SQLInjectionValidator.validateDynamicQuery(columnValue);
+ if (strict) {
Review Comment:
strict: for stored procedures we do not want to validate the column values
against injections to be inserted/updated/searched for.
sqlGenerator parameter instead of dialect, to fulfil @galovics request to
avoid static methods on services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
