b0c1 commented on code in PR #3401:
URL: https://github.com/apache/fineract/pull/3401#discussion_r1308734131
##########
fineract-provider/src/main/java/org/apache/fineract/organisation/office/service/OfficeReadPlatformServiceImpl.java:
##########
@@ -34,35 +37,29 @@
import
org.apache.fineract.organisation.monetary.service.CurrencyReadPlatformService;
import org.apache.fineract.organisation.office.data.OfficeData;
import org.apache.fineract.organisation.office.data.OfficeTransactionData;
+import org.apache.fineract.organisation.office.domain.OfficeRepository;
import
org.apache.fineract.organisation.office.exception.OfficeNotFoundException;
+import org.apache.fineract.organisation.office.mapper.OfficeDataMapper;
import org.apache.fineract.useradministration.domain.AppUser;
-import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.cache.annotation.Cacheable;
import org.springframework.dao.EmptyResultDataAccessException;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.RowMapper;
import org.springframework.stereotype.Service;
@Service
+@RequiredArgsConstructor
public class OfficeReadPlatformServiceImpl implements
OfficeReadPlatformService {
private final JdbcTemplate jdbcTemplate;
private final DatabaseSpecificSQLGenerator sqlGenerator;
private final PlatformSecurityContext context;
private final CurrencyReadPlatformService currencyReadPlatformService;
private final ColumnValidator columnValidator;
- private static final String nameDecoratedBaseOnHierarchy =
"concat(substring('........................................', 1,
((LENGTH(o.hierarchy) - LENGTH(REPLACE(o.hierarchy, '.', '')) - 1) * 4)),
o.name)";
- @Autowired
- public OfficeReadPlatformServiceImpl(final PlatformSecurityContext context,
- final CurrencyReadPlatformService currencyReadPlatformService,
final JdbcTemplate jdbcTemplate,
- final ColumnValidator columnValidator,
DatabaseSpecificSQLGenerator sqlGenerator) {
- this.context = context;
- this.currencyReadPlatformService = currencyReadPlatformService;
- this.columnValidator = columnValidator;
- this.jdbcTemplate = jdbcTemplate;
- this.sqlGenerator = sqlGenerator;
- }
+ private final OfficeRepository officeRepository;
+ private final OfficeDataMapper officeDataMapper;
+ private static final String nameDecoratedBaseOnHierarchy =
"concat(substring('........................................', 1,
((LENGTH(o.hierarchy) - LENGTH(REPLACE(o.hierarchy, '.', '')) - 1) * 4)),
o.name)";
Review Comment:
Still needed for the old codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
