adamsaghy commented on code in PR #3411:
URL: https://github.com/apache/fineract/pull/3411#discussion_r1311569574


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java:
##########
@@ -65,5 +66,8 @@ SavingsAccount 
findByIdAndDepositAccountType(@Param("accountId") Long accountId,
 
     Page<SavingsAccount> findByStatus(Integer status, Pageable pageable);
 
-    SavingsAccount findByExternalId(String externalId);
+    SavingsAccount findByExternalId(ExternalId externalId);
+
+    @Query("SELECT sa.id FROM SavingsAccount sa WHERE sa.externalId = 
:externalId")

Review Comment:
   This method would work without the `@Query` annotation as well! ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to