adamsaghy commented on code in PR #3409:
URL: https://github.com/apache/fineract/pull/3409#discussion_r1311616319
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -78,6 +79,14 @@ public static LocalDateTime getLocalDateTimeOfSystem() {
return
LocalDateTime.now(ZoneId.systemDefault()).truncatedTo(ChronoUnit.SECONDS);
}
+ public static LocalDateTime getAuditLocalDateTime() {
Review Comment:
I would be happier if this would be moved into a new PR and change every
places to use this instead of the LocalDateTime.now with system TZ.
I reckon it was said in the Readme the application should be run on server
with UTC, so should be no issue since LocalDateTime.now(UTC) and
LocalDateTime.now(SystemTimeZone) should be equals, but still for consistency
purposes it would be better to use only one of them.
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -78,6 +79,14 @@ public static LocalDateTime getLocalDateTimeOfSystem() {
return
LocalDateTime.now(ZoneId.systemDefault()).truncatedTo(ChronoUnit.SECONDS);
}
+ public static LocalDateTime getAuditLocalDateTime() {
Review Comment:
I would be happier if this would be moved into a new PR and change every
places to use this instead of the LocalDateTime.now with system TZ.
I reckon it was said in the Readme the application should be run on server
with UTC, so should be no issue since LocalDateTime.now(UTC) and
LocalDateTime.now(SystemTimeZone) should be equals, but still for consistency
purposes it would be better to use only one of them.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
