adamsaghy commented on code in PR #3467: URL: https://github.com/apache/fineract/pull/3467#discussion_r1334386260
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java: ########## @@ -430,6 +435,30 @@ private LoanScheduleModel generate(final MathContext mc, final LoanApplicationTe totalOutstanding); } + private void checkDownPaymentInstallmentForOverlappingInstallments(Collection<LoanScheduleModelPeriod> periods, + LocalDate scheduledDueDate) { + Integer downPaymentPeriodNumber = 0; + Integer repaymentPeriodNumber = 0; + List<LoanScheduleModelPeriod> overlappingPeriods = periods.stream() + .filter(p -> p.periodDueDate() != null && p.periodDueDate().isEqual(scheduledDueDate)) + .sorted(Comparator.comparing(LoanScheduleModelPeriod::periodNumber)).toList(); + if (overlappingPeriods.size() == 2) { Review Comment: what would happen if i disburse two times or 3 times on the same day as the due date? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org