adamsaghy commented on code in PR #3471:
URL: https://github.com/apache/fineract/pull/3471#discussion_r1336840455


##########
fineract-core/src/main/java/org/apache/fineract/commands/service/CommandSourceService.java:
##########
@@ -48,46 +48,34 @@ public class CommandSourceService {
     private final CommandSourceRepository commandSourceRepository;
     private final ErrorHandler errorHandler;
 
-    @Transactional(propagation = Propagation.REQUIRES_NEW, isolation = 
Isolation.REPEATABLE_READ)
-    public CommandSource saveInitial(CommandWrapper wrapper, JsonCommand 
jsonCommand, AppUser maker, String idempotencyKey) {
-        return saveInitialInternal(wrapper, jsonCommand, maker, 
idempotencyKey);
-    }
-
-    public CommandSource saveInitialNoTransaction(CommandWrapper wrapper, 
JsonCommand jsonCommand, AppUser maker, String idempotencyKey) {

Review Comment:
   Can you please help me understand why we dont need anymore the "no 
transaction" version of this anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to