reluxa commented on code in PR #3496:
URL: https://github.com/apache/fineract/pull/3496#discussion_r1363677746


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1657,7 +1657,7 @@ private String getClientOfficeJoinCondition(String 
officeHierarchy, String appTa
     }
 
     private String getGroupOfficeJoinCondition(String officeHierarchy, String 
appTableAlias) {
-        return " join m_group g on g.id = " + appTableAlias + ".client_id " + 
getOfficeJoinCondition(officeHierarchy, "g");
+        return " join m_group g on g.id = " + appTableAlias + ".group_id " + 
getOfficeJoinCondition(officeHierarchy, "g");

Review Comment:
   Probably we might want to add a integration test which covers. Just to make 
sure that it is still working as it should.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to