vidakovic commented on code in PR #3533:
URL: https://github.com/apache/fineract/pull/3533#discussion_r1373193184
##########
fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryReadPlatformServiceImpl.java:
##########
@@ -23,18 +23,14 @@
import java.util.Collection;
import org.apache.fineract.infrastructure.core.domain.JdbcSupport;
import
org.apache.fineract.organisation.provisioning.data.ProvisioningCategoryData;
-import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.RowMapper;
-import org.springframework.stereotype.Service;
-@Service
public class ProvisioningCategoryReadPlatformServiceImpl implements
ProvisioningCategoryReadPlatformService {
private final JdbcTemplate jdbcTemplate;
private final ProvisioningCategoryRowMapper provisionCategoryRowMapper;
- @Autowired
public ProvisioningCategoryReadPlatformServiceImpl(final JdbcTemplate
jdbcTemplate) {
Review Comment:
Again, constructor can be avoided. Please use the required args annotation
and instantiate the provision category row mapper in one line:
```
private final ProvisioningCategoryRowMapper provisionCategoryRowMapper = new
ProvisioningCategoryRowMapper();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
