adamsaghy commented on code in PR #3544:
URL: https://github.com/apache/fineract/pull/3544#discussion_r1375230970


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -176,6 +178,153 @@ private void handleRepayment(LoanTransaction 
loanTransaction, MonetaryCurrency c
             loanTransaction.resetDerivedComponents();
         }
         Money transactionAmountUnprocessed = 
loanTransaction.getAmount(currency);
+        handleOverAmount(loanTransaction, currency, installments, 
transactionAmountUnprocessed, charges);

Review Comment:
   Please rename this method hence it is not always about to handle 
overamount... a processTransaction would make more sense to me...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to