vidakovic commented on code in PR #3568:
URL: https://github.com/apache/fineract/pull/3568#discussion_r1383754429
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/event/external/exception/ExternalEventConfigurationNotFoundException.java:
##########
@@ -21,7 +21,7 @@
public class ExternalEventConfigurationNotFoundException extends
RuntimeException {
public ExternalEventConfigurationNotFoundException() {
- super("All external events are not configured");
+ super("No external events configured");
Review Comment:
Renaming the exception doesn't seem to have any unintended side effect... I
did it, because "All ... are not" is simply just "No...". It's just a question
of brevity... I think you would say "All external events are configured" for
the positive case, but "No external events configured" for the negative case
(i. e. this failure/exception situation). "All external events are not
configured" sounds a bit weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
