adamsaghy commented on code in PR #3572:
URL: https://github.com/apache/fineract/pull/3572#discussion_r1385387426
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java:
##########
@@ -170,15 +170,15 @@ private static Collection<LocalDate>
getRecurringDates(final Recur recur, final
numberOfDays);
}
- private static Collection<LocalDate> convertToLocalDateList(final DateList
dates, final LocalDate seedDate,
+ static Collection<LocalDate> convertToLocalDateList(final DateList dates,
final LocalDate seedDate,
final PeriodFrequencyType frequencyType, boolean
isSkippMeetingOnFirstDay, final Integer numberOfDays) {
final Collection<LocalDate> recurringDates = new ArrayList<>();
- for (@SuppressWarnings("rawtypes")
- final Iterator iterator = dates.iterator(); iterator.hasNext();) {
- final Date date = (Date) iterator.next();
- recurringDates.add((LocalDate)
adjustDate(LocalDate.ofInstant(date.toInstant(),
DateUtils.getDateTimeZoneOfTenant()), seedDate,
- frequencyType));
+ for (final Date date : dates) {
+ LocalDateTime dateTimeInProperTz =
getLocalDateTimeFromICal4JDate(date);
Review Comment:
It would be nice to find a way to move away from Calendar...and make it work
with Java date / datetime...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
