reluxa commented on code in PR #3597:
URL: https://github.com/apache/fineract/pull/3597#discussion_r1403330869
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -779,8 +779,10 @@ private void handleChargePaidTransaction(final LoanCharge
charge, final LoanTran
.determineProcessor(this.transactionProcessingStrategyCode);
final List<LoanRepaymentScheduleInstallment> chargePaymentInstallments
= new ArrayList<>();
List<LoanRepaymentScheduleInstallment> installments =
getRepaymentScheduleInstallments();
+ int firstNormalInstallmentNumber =
LoanRepaymentScheduleProcessingWrapper
+
.fetchFirstNormalInstallmentNumber(repaymentScheduleInstallments);
for (final LoanRepaymentScheduleInstallment installment :
installments) {
- boolean isDue = installment.isFirstPeriod()
+ boolean isDue =
installment.getInstallmentNumber().equals(firstNormalInstallmentNumber)
Review Comment:
I know that it was here before, but I was wondering why `isDue` is the
proper variable name here. Imo sameInstallment would be more appropriate isn't
it, or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
