mariiaKraievska commented on code in PR #3555:
URL: https://github.com/apache/fineract/pull/3555#discussion_r1403544593
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##########
@@ -139,7 +139,8 @@ public CommandProcessingResult executeCommand(final
CommandWrapper wrapper, fina
commandSource.setCommandJson(toApiJsonSerializer.serializeResult(result.getChanges()));
}
- commandSource =
commandSourceService.saveResultSameTransaction(commandSource);
+ commandSource = sameTransaction ?
commandSourceService.saveResultSameTransaction(commandSource)
+ : commandSourceService.saveResultNewTransaction(commandSource);
Review Comment:
@marta-jankovics Thank you for your answer. Please read the attached
document in which I have answered your question on the paragraph described in
your last comment "**2. Batch request without enclosing transaction**" as well
as described my changes from the last commit, which relates to the paragraph
"**3. Batch request with enclosing transaction**". If my solution is
appropriate, I will squash the commits and add a test. Thank you, I am waiting
for your reply.
[Detailed
response.docx](https://github.com/apache/fineract/files/13451772/Detailed.response.docx)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
