reluxa commented on code in PR #3604:
URL: https://github.com/apache/fineract/pull/3604#discussion_r1406428259
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java:
##########
@@ -143,8 +149,7 @@ public CollectionData calculateLoanCollectionData(final
Long loanId) {
collectionData.setLastRepaymentAmount(lastRepaymentTransaction.getAmount());
}
- enrichWithDelinquencyPausePeriodInfo(collectionData,
retrieveLoanDelinquencyActions(loanId),
- ThreadLocalContextUtil.getBusinessDate());
+ enrichWithDelinquencyPausePeriodInfo(collectionData,
savedDelinquencyList, ThreadLocalContextUtil.getBusinessDate());
Review Comment:
The effective delinquency list is already calculated in line 133, so we can
add that instead of the full savedDelinquencyList, then the enrich method would
not need to do this calculation again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
