adamsaghy commented on code in PR #3605:
URL: https://github.com/apache/fineract/pull/3605#discussion_r1407633758
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java:
##########
@@ -395,6 +397,16 @@ protected void
reprocessInstallments(List<LoanRepaymentScheduleInstallment> inst
if
(loanRepaymentScheduleInstallment.getTotalOutstanding(currency).isGreaterThanZero())
{
loanRepaymentScheduleInstallment.updateObligationMet(false);
loanRepaymentScheduleInstallment.updateObligationMetOnDate(null);
+ } else {
+ Optional<LoanTransaction> optWaiverTx =
transactions.stream().filter(lt -> {
+ LocalDate fromDate =
loanRepaymentScheduleInstallment.getFromDate();
+ return lt.getSubmittedOnDate().isAfter(fromDate);
Review Comment:
i think you need to use the transaction date here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
