adamsaghy commented on code in PR #3608:
URL: https://github.com/apache/fineract/pull/3608#discussion_r1409133559
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3713,14 +3713,14 @@ public Integer getSubStatus() {
public void validateForAccountBlock() {
final SavingsAccountSubStatusEnum currentSubStatus =
SavingsAccountSubStatusEnum.fromInt(this.getSubStatus());
if (SavingsAccountSubStatusEnum.BLOCK.hasStateOf(currentSubStatus)) {
- throw new SavingsAccountBlockedException(this.getId());
+ throw new SavingsAccountBlockedException(getAccountNumber());
Review Comment:
Please extend the parameters list with the account number instead of
overriding the account id. There might be consumers who built logic on top of
the parameters list of this exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
