adamsaghy commented on code in PR #3640:
URL: https://github.com/apache/fineract/pull/3640#discussion_r1427852299
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationCommandFromApiJsonHelper.java:
##########
@@ -396,6 +396,12 @@ public void validateForCreate(final String json, final
boolean isMeetingMandator
.extractStringNamed(LoanApiConstants.transactionProcessingStrategyCodeParameterName,
element);
baseDataValidator.reset().parameter(LoanApiConstants.transactionProcessingStrategyCodeParameterName)
.value(transactionProcessingStrategy).notNull();
+
+ if
(!transactionProcessingStrategy.equals(loanProduct.getTransactionProcessingStrategyCode()))
{
Review Comment:
This is not correct. You can change the transaction processing strategy
before you are submitting a loan, except the "Advanced payment allocation"
which is required to be set on loan product properly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
