adamsaghy commented on code in PR #3645:
URL: https://github.com/apache/fineract/pull/3645#discussion_r1431352716
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/jobs/applyholidaystoloans/ApplyHolidaysToLoansTasklet.java:
##########
@@ -129,13 +131,13 @@ private void adjustRepaymentSchedules(Loan loan, Holiday
holiday, LocalDate adju
loanRepaymentScheduleInstallment.updateFromDate(tmpFromDate);
}
- if (!DateUtils.isBefore(oldDueDate, holiday.getFromDate())) {
+ if (isDateWithinRange(oldDueDate, holiday.getFromDate(),
holiday.getToDate())) {
// FIXME: AA do we need to apply non-working days.
// Assuming holiday's repayment reschedule to date cannot be
// created on a non-working day.
- adjustedRescheduleToDate =
scheduledDateGenerator.generateNextRepaymentDate(adjustedRescheduleToDate,
loanApplicationTerms,
- false);
+ adjustedRescheduleToDate =
scheduledDateGenerator.generateNextRepaymentDateWhenHolidayApply(adjustedRescheduleToDate,
+ loanApplicationTerms);
Review Comment:
Can you please fix an another issue?
Line 90: holiday.isProcessed() -> holiday.setProcessed(true);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
