Rajkumar-Selvaraj opened a new pull request, #3654: URL: https://github.com/apache/fineract/pull/3654
issuse resolved in loanaccount data. Issue - When I assign loan product to a client, I got an "NullpointerException" when the Borrowcycle is true in the loan product. The reason behind is The loanCycle number is null by default, When the borrowcycle is enable in the loan product, There is an "if" condition on the "LoanAccountData" which compares the loancyclenumber with 0 to see whether the loancycle number greater zero or not. We can't comapre an null with an int value in the "if" class. ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
