adamsaghy commented on code in PR #3657:
URL: https://github.com/apache/fineract/pull/3657#discussion_r1438869260
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -500,7 +500,7 @@ public static LoanAccountData
loanProductWithTemplateDefaults(final LoanProductD
BigDecimal interestRatePerPeriod = null;
Integer numberOfRepayments = null;
- if (product.isUseBorrowerCycle() && loanCycleNumber > 0) {
+ if (product.isUseBorrowerCycle() && loanCycleNumber !=null &&
loanCycleNumber > 0) {
Review Comment:
Please add an integration test to cover this enhanced functionality!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
