adamsaghy commented on code in PR #3658:
URL: https://github.com/apache/fineract/pull/3658#discussion_r1438869810
##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0087_update_dashboard_table_reports.xml:
##########
@@ -75,7 +75,7 @@
FROM m_office o LEFT JOIN m_client cl on o.id = cl.office_id
LEFT JOIN m_loan ln on cl.id = ln.client_id
WHERE o.hierarchy like concat((select ino.hierarchy from m_office
ino where ino.id = ${officeId}),'%' )
- AND (ln.disbursedon_date BETWEEN DATE_SUB(CURDATE(), INTERVAL
12 DAY) AND DATE(NOW()- INTERVAL '1 DAY'))
+ AND (ln.disbursedon_date BETWEEN DATE_SUB(CURDATE(), INTERVAL
12 DAY) AND DATE(NOW()- INTERVAL 1 DAY))
Review Comment:
The same issue might appear in other reports as well. Can you please cover
them in this PR?
Also please make sure you have an integration test which cover the issue was
truly fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
