adamsaghy commented on PR #3630:
URL: https://github.com/apache/fineract/pull/3630#issuecomment-1889526919

   > @adamsaghy , Yes the number of previous passwords is configurable but we 
have a hardcoded values to act like a default.When the configuration is 
disabled. On assumption a user won't hit. So the change password on 
enable/disable will keep checking but since we have a default with a high cap. 
This won't catch him
   
   I dont like the hardcoded value. If the functionality is disabled, then 
there should be **no** any check for previous passwords.
   The new configuration should be **turned on by default** and you might wanna 
set it for a higher number if you think 3 is not reasonable.
   
   If the reuse is disabled, we shall not throw an error if the user wanna 
update its password.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to