vidakovic commented on code in PR #3764:
URL: https://github.com/apache/fineract/pull/3764#discussion_r1503013965
##########
fineract-savings/src/main/java/org/apache/fineract/interoperation/data/InteropIdentifierData.java:
##########
@@ -19,41 +19,28 @@
package org.apache.fineract.interoperation.data;
import jakarta.validation.constraints.NotNull;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
import org.apache.fineract.interoperation.domain.InteropIdentifier;
import org.apache.fineract.interoperation.domain.InteropIdentifierType;
+@Getter
+@AllArgsConstructor
public class InteropIdentifierData {
@NotNull
- private final InteropIdentifierType idType;
Review Comment:
@adamsaghy I think the idea is to better use the builder pattern instead of
a gigantic (depending on number of class attributes) constructor with "57"
string parameters (I am exaggerating).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
