reluxa commented on code in PR #3782:
URL: https://github.com/apache/fineract/pull/3782#discussion_r1516211247
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanRepaymentScheduleWithDownPaymentTest.java:
##########
@@ -1403,10 +1403,14 @@ public void downPaymentOnOverpaidProgressiveLoan() {
transaction(1000.0, "Disbursement", "03 March 2023",
1000.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0), //
transaction(250.0, "Down Payment", "03 March 2023", 750.0,
250.0, 0.0, 0.0, 0.0, 0.0, 0.0), //
transaction(800.0, "Repayment", "03 March 2023", 0.0,
750.0, 0.0, 0.0, 0.0, 0.0, 50.0), //
- transaction(20.0, "Disbursement", "05 March 2023", 0.0,
0.0, 0.0, 0.0, 0.0, 0.0, 30.0), //
- transaction(30.0, "Disbursement", "05 March 2023", 0.0,
0.0, 0.0, 0.0, 0.0, 0.0, 0.0), //
+ transaction(20.0, "Disbursement", "05 March 2023", 0.0,
0.0, 0.0, 0.0, 0.0, 0.0, 20.0), //
+ transaction(30.0, "Disbursement", "05 March 2023", 0.0,
0.0, 0.0, 0.0, 0.0, 0.0, 30.0), //
transaction(1.0, "Repayment", "05 March 2023", 0.0, 0.0,
0.0, 0.0, 0.0, 0.0, 1.0, true), //
- transaction(40.0, "Disbursement", "05 March 2023", 40.0,
0.0, 0.0, 0.0, 0.0, 0.0, 0.0), //
+ transaction(40.0, "Disbursement", "05 March 2023", 40.0,
0.0, 0.0, 0.0, 0.0, 0.0, 0.0), // TODO:
Review Comment:
@adamsaghy : Could you please take a look to the last disbursement here?
Should not this be 1.0 instead of 0.0 due the 1.0 repayment that we have in the
previous line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
