adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521172954
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -496,7 +532,15 @@ private void processSingleTransaction(LoanTransaction
loanTransaction, MonetaryC
* For existing transactions, check if the re-payment breakup
(principal, interest, fees, penalties) has
* changed.<br>
*/
- final LoanTransaction newLoanTransaction =
LoanTransaction.copyTransactionProperties(loanTransaction);
+ LoanTransaction newLoanTransaction =
LoanTransaction.copyTransactionProperties(loanTransaction);
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ if (loanTransaction.getTypeOf().equals(REAMORTIZE)) {
Review Comment:
I dont think we need this.
I think the original logic should collect the outstanding principal amounts
and check whether the new balance is matching with the original transaction
amount or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
