adamsaghy commented on code in PR #3794:
URL: https://github.com/apache/fineract/pull/3794#discussion_r1528516247
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/jobs/executestandinginstructions/ExecuteStandingInstructionsTasklet.java:
##########
@@ -97,7 +97,8 @@ public RepeatStatus execute(StepContribution contribution,
ChunkContext chunkCon
transactionAmount =
standingInstructionDuesData.totalDueAmount();
}
if (recurrenceType.isDuesRecurrence()) {
- isDueForTransfer =
LocalDate.now(DateUtils.getDateTimeZoneOfTenant()).equals(standingInstructionDuesData.dueDate());
+ isDueForTransfer = recurrenceType.isDuesRecurrence() &&
standingInstructionDuesData.dueDate() != null
Review Comment:
i am not sure the job should pick up "earlier" standing instructions than
the today's date.
@bharathc27 Could you please advise here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
