adamsaghy commented on code in PR #3808:
URL: https://github.com/apache/fineract/pull/3808#discussion_r1531760622


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractProgressiveLoanScheduleGenerator.java:
##########
@@ -128,6 +145,16 @@ public LoanScheduleModel generate(final MathContext mc, 
final LoanApplicationTer
 
             if (!isNextRepaymentAvailable) {
                 scheduleParams.getDisburseDetailMap().clear();
+
+                // Fixed Length Validations - If the Number or Repayments 
requested is greater than current/last
+                // Installment number
+                if (loanApplicationTerms.getFixedLength() != null

Review Comment:
   This should be validated in the validator, not during the schedule 
generation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to