adamsaghy commented on code in PR #3791:
URL: https://github.com/apache/fineract/pull/3791#discussion_r1535299728
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/FixedDepositTest.java:
##########
@@ -153,9 +153,13 @@ public void
testFixedDepositInterestCalculationWithWrongCompoundingPeriod() {
JsonElement element = parser.parse(apiRequestBodyAsJson);
fixedDepositAccountInterestCalculationServiceImpl = new
FixedDepositAccountInterestCalculationServiceImpl(
new DepositAccountDataValidator(new FromJsonHelper(), null),
new FromJsonHelper());
-
- assertThrows(PlatformApiDataValidationException.class, () ->
fixedDepositAccountInterestCalculationServiceImpl
Review Comment:
This is also valid, but assertThrows can return the exception object which
was raised and you can assert it, but like i said. this is fine also ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
