Aboya1417 opened a new pull request, #3842: URL: https://github.com/apache/fineract/pull/3842
…ded integration test and swagger documentation ## Description We want the loan account summary data to contain currency as we will like to know the currencies tied to different loan products during setup. The client account endpoint https://baseurl/fineract-provider/api/v1/clients/23/accounts returns a payload containing both savings and loan account, the savings account summary contains currency while the loan account summary does not contain currency. The aim is to replicate what already exist on the savings account summary for the loan account summary by bringing in currency. This Jira ticket [FINERACT-2020](https://issues.apache.org/jira/browse/FINERACT-2020) contains more vivid description. Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
