wkigenyi commented on code in PR #3795:
URL: https://github.com/apache/fineract/pull/3795#discussion_r1545551081
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultPaymentPeriodsInOneYearCalculator.java:
##########
@@ -32,15 +32,15 @@
public class DefaultPaymentPeriodsInOneYearCalculator implements
PaymentPeriodsInOneYearCalculator {
@Override
- public Integer calculate(final PeriodFrequencyType repaymentFrequencyType)
{
+ public Integer calculate(final PeriodFrequencyType
repaymentFrequencyType,final PeriodFrequencyType interestRateFrequencyMethod) {
Integer paymentPeriodsInOneYear = 0;
switch (repaymentFrequencyType) {
case DAYS:
- paymentPeriodsInOneYear = 365;
+ paymentPeriodsInOneYear =
interestRateFrequencyMethod.isMonthly() ? Integer.valueOf(360) :
Integer.valueOf(365);
Review Comment:
With monthly interest interest and daily repayments, it looks more
reasonable to assume that there are exactly 360 days, a number divisible by the
12 months in the year brings our more explainable installments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
