Zeyad2003 commented on code in PR #3843:
URL: https://github.com/apache/fineract/pull/3843#discussion_r1545885716
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/GSIMReadPlatformServiceImpl.java:
##########
@@ -73,8 +73,11 @@ public GroupSavingsIndividualMonitoringAccountData
mapRow(final ResultSet rs, @S
final BigDecimal parentBalance = rs.getBigDecimal("parentBalance");
final BigDecimal childBalance = rs.getBigDecimal("childBalance");
final String savingsStatus =
SavingsAccountStatusType.fromInt((int) rs.getLong("savingsStatus")).toString();
- return
GroupSavingsIndividualMonitoringAccountData.getInstance2(gsimId, groupId,
clientId, accountNumber, childAccountId,
- childAccountNumber, parentBalance, childBalance,
childAccountsCount, savingsStatus);
+
+ return
GroupSavingsIndividualMonitoringAccountData.builder().gsimId(gsimId).groupId(groupId).clientId(clientId)
+
.accountNumber(accountNumber).childAccountId(childAccountId).childAccountNumber(childAccountNumber)
+
.childDeposit(parentBalance).parentDeposit(childBalance).childAccountsCount(childAccountsCount)
Review Comment:
When assigning `parentBalance` to `childDeposite` and assign `childBalance`
to `parentDeposit`, it's a bit ambiguous to me due to convention, but I just
followed the previous implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
