adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559161789
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/jobs/executestandinginstructions/ExecuteStandingInstructionsTasklet.java:
##########
@@ -113,8 +120,12 @@ public RepeatStatus execute(StepContribution contribution,
ChunkContext chunkCon
final boolean transferCompleted = transferAmount(errors,
accountTransferDTO, data.getId());
if (transferCompleted) {
- final String updateQuery = "UPDATE
m_account_transfer_standing_instructions SET last_run_date = ? where id = ?";
- jdbcTemplate.update(updateQuery, transactionDate,
data.getId());
+ final JPAQueryFactory queryFactory = new
JPAQueryFactory(this.entityManager);
Review Comment:
I would move this whole logic into an AccountTransferStandingInstruction
repository. We can change our repository interfaces to an impl where queryDSL
is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
