adamsaghy commented on code in PR #3873:
URL: https://github.com/apache/fineract/pull/3873#discussion_r1579202597
##########
fineract-core/src/main/java/org/apache/fineract/organisation/monetary/domain/MoneyHelper.java:
##########
@@ -59,4 +63,11 @@ public static MathContext getMathContext() {
}
return mathContext;
}
+
+ @Profile(FineractProfiles.TEST)
Review Comment:
I dont think profile do anything here..l its a static method...part of the
class... :/
Also MoneyHelper has not much to do with configuration rounding mode.
Would you mind moving this logic into the ConfigurationDomainService without
the profile annotation? The profile annotation do absolutely nothing here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
