adamsaghy commented on code in PR #3886:
URL: https://github.com/apache/fineract/pull/3886#discussion_r1595154446
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationCommandFromApiJsonHelper.java:
##########
@@ -581,6 +582,21 @@ public void validateForCreate(final String json, final
boolean isMeetingMandator
}
validatePartialPeriodSupport(interestCalculationPeriodType,
baseDataValidator, element, loanProduct);
+
+ // validate enable installment level delinquency
+ if
(this.fromApiJsonHelper.parameterExists(LoanProductConstants.ENABLE_INSTALLMENT_LEVEL_DELINQUENCY,
element)) {
+ if (loanProduct.getDelinquencyBucket() == null) {
+
baseDataValidator.reset().parameter(LoanProductConstants.ENABLE_INSTALLMENT_LEVEL_DELINQUENCY).failWithCode(
+ "supported.for.loan.products.with.delinquency.bucket",
+ "Installment level delinquency is supported for loan
products with delinquency bucket");
Review Comment:
I am not sure this error message explains the problem if installment level
delinquency is enabled but no delinquency bucket is set. Can you please double
check whether we can explain this more in details to avoid confusions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
