adamsaghy commented on code in PR #3892:
URL: https://github.com/apache/fineract/pull/3892#discussion_r1604794685
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##########
@@ -809,6 +809,14 @@ public void validateForCreate(final JsonCommand command) {
"Progressive repayment schedule processing is only
available with `Advanced payment allocation` strategy");
}
+ if
(LoanScheduleType.PROGRESSIVE.equals(LoanScheduleType.valueOf(loanScheduleType))
Review Comment:
Please extract this validation into a method and that way can be reused when
loan got submitted or when loan got modified!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
