adamsaghy commented on code in PR #3913:
URL: https://github.com/apache/fineract/pull/3913#discussion_r1624305864
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -1389,6 +1387,12 @@ private void applyPeriodicAccruals(final
Collection<LoanTransaction> accruals) {
}
}
+ private LocalDate getDateForRangeCalculation(LoanTransaction
loanTransaction, boolean isChargeAccrualBasedOnSubmittedOnDate) {
Review Comment:
It looks better, however i was wondering what if the loan charge is not a
specific due date charge? Would it be better to call `getEffectiveDueDate()`
method which covers the proper due date for installment charge as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
