adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634957165
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -4796,33 +4434,11 @@ public LoanTransaction
getLastRepaymentOrDownPaymentTransaction() {
}
public LocalDate getLastUserTransactionForChargeCalc() {
- LocalDate lastTransaction = getDisbursementDate();
- if (this.repaymentScheduleDetail().isInterestRecalculationEnabled()) {
- lastTransaction = getLastUserTransactionDate();
- }
- return lastTransaction;
+ return this.repaymentScheduleDetail().isInterestRecalculationEnabled()
? getLastUserTransactionDate() : getLastRepaymentDate();
Review Comment:
I know you will not like this one, but here the `getDisbursementDate()` need
to be used and just leave comment, this needs to be reviewed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]