adamsaghy commented on code in PR #3926:
URL: https://github.com/apache/fineract/pull/3926#discussion_r1635254306
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##########
@@ -102,6 +103,11 @@ public CommandProcessingResult executeCommand(final
CommandWrapper wrapper, fina
} else {
idempotencyKey = idempotencyKeyResolver.resolve(wrapper);
}
+ // Idempotency key lebgth validation
+ if (!StringUtils.isEmpty(idempotencyKey) && idempotencyKey.length() >
50) {
Review Comment:
This seems not right. If the idempotency key is too long, we should have a
domain rule exception (HTTP 403) that describes the issue. The issue was when
it happened the error message title and message was incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]